Skip to content

BRE-609/update-workflows #14666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

BRE-609/update-workflows #14666

merged 3 commits into from
May 15, 2025

Conversation

aj-bw
Copy link
Member

@aj-bw aj-bw commented May 7, 2025

🎟️ Tracking

BRE-609

📔 Objective

update workflows to be compliant with pull_request_target workflow linter rule ahead of changing rule log level to error

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.23%. Comparing base (df40954) to head (6c9f9b4).
Report is 113 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14666      +/-   ##
==========================================
- Coverage   36.26%   36.23%   -0.04%     
==========================================
  Files        3190     3191       +1     
  Lines       92376    92281      -95     
  Branches    16598    16555      -43     
==========================================
- Hits        33504    33436      -68     
+ Misses      56468    56459       -9     
+ Partials     2404     2386      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 7, 2025

Logo
Checkmarx One – Scan Summary & Details3cd9786b-2da3-4d9d-a57c-a7832e2155d0

Great job, no security vulnerabilities found in this Pull Request

Copy link

sonarqubecloud bot commented May 7, 2025

@aj-bw aj-bw changed the title BRE-90/update-workflows BRE-609/update-workflows May 7, 2025
@aj-bw aj-bw marked this pull request as ready for review May 13, 2025 16:02
@aj-bw aj-bw requested a review from a team as a code owner May 13, 2025 16:02
@aj-bw aj-bw requested a review from coroiu May 13, 2025 16:02
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@aj-bw aj-bw merged commit 0c2b924 into main May 15, 2025
28 checks passed
@aj-bw aj-bw deleted the BRE-609/update-workflows branch May 15, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants