Skip to content

[PM-21435] Risk insights - Default uri #14800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Banrion
Copy link
Contributor

@Banrion Banrion commented May 15, 2025

🎟️ Tracking

PM-21435

📔 Objective

This pull request changes the Application column data to display the original uri if the Application name cannot be derived. This accounts for invalid uris that may have been entered or saved.

📸 Screenshots

Before

image

After

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Banrion Banrion requested a review from a team as a code owner May 15, 2025 14:29
@Banrion Banrion added the needs-qa Marks a PR as requiring QA approval label May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.61%. Comparing base (bacd1fb) to head (efc69c6).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14800      +/-   ##
==========================================
+ Coverage   36.57%   36.61%   +0.04%     
==========================================
  Files        3194     3195       +1     
  Lines       92200    92447     +247     
  Branches    16538    16629      +91     
==========================================
+ Hits        33719    33849     +130     
- Misses      56080    56128      +48     
- Partials     2401     2470      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Banrion Banrion changed the title [PM-21435] Update risk insights report to default an invalid uri to the original… [PM-21435] Risk insights - Default uri May 15, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0dc2c7e0-522f-4332-b325-b16f6de5f9cb

Great job, no security vulnerabilities found in this Pull Request

@ttalty ttalty self-requested a review May 15, 2025 18:24
Copy link
Contributor

@ttalty ttalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants