Skip to content

[PM-14469] Removing critical applications feature flag and logic #14889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ttalty
Copy link
Contributor

@ttalty ttalty commented May 22, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14469

📔 Objective

Removing client feature flag for critical applications. Any related logic has also been removed.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ttalty ttalty requested a review from a team as a code owner May 22, 2025 19:10
@ttalty ttalty added the needs-qa Marks a PR as requiring QA approval label May 22, 2025
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details527cb68e-5385-451b-849a-c665b8277454

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.49%. Comparing base (9417d8a) to head (05669c1).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14889      +/-   ##
==========================================
+ Coverage   36.42%   36.49%   +0.06%     
==========================================
  Files        3212     3207       -5     
  Lines       93266    93238      -28     
  Branches    16837    16836       -1     
==========================================
+ Hits        33972    34027      +55     
+ Misses      56826    56736      -90     
- Partials     2468     2475       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant