Skip to content

[PM-21957][Defect][Web] "Add payment method" modal does not pop-up #14941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21957

📔 Objective

Precondition: Have an organization in suspended mode by having invoices past due.
Payment method can be removed and can generate invoices via stripe.

1.Log into web (USQA)
2.On the vaults page under all vaults select the suspended organization (indicated by a red triangle warning sign)
3.On the “The X is suspended” pop-up select continue

Expected: When a user selects a suspended org via the vault page they are redirected to the “Add payment method” modal
Example: video shows expected redirect to modal
(note: suspended org was selected via admin console instead of the vaults page)

📸 Screenshots

Screen.Recording.2025-05-26.at.11.34.24.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner May 26, 2025 10:35
Copy link
Contributor

github-actions bot commented May 26, 2025

Logo
Checkmarx One – Scan Summary & Details0e0e5faa-1bc6-4571-8ce8-0f56f576dd1c

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (95856bf) to head (649315a).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nt-method/organization-payment-method.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14941      +/-   ##
==========================================
- Coverage   36.82%   36.82%   -0.01%     
==========================================
  Files        3199     3199              
  Lines       92749    92752       +3     
  Branches    13924    13925       +1     
==========================================
  Hits        34155    34155              
- Misses      57188    57191       +3     
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jun 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants