Skip to content

[PM-22111] Migrate emergency access to standalone #14958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 27, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22111

📔 Objective

Migrate emergency access to standalone.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton changed the title Migrate emergency access to standalone [PM-22111] Migrate emergency access to standalone May 27, 2025
Copy link

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.26%. Comparing base (a6e2012) to head (60185e4).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ngs/emergency-access/emergency-access.component.ts 0.00% 3 Missing ⚠️
...ency-access/emergency-access-add-edit.component.ts 0.00% 2 Missing ⚠️
...ss/takeover/emergency-access-takeover.component.ts 0.00% 2 Missing ⚠️
...cess/confirm/emergency-access-confirm.component.ts 0.00% 1 Missing ⚠️
...ncy-access/view/emergency-access-view.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14958      +/-   ##
==========================================
- Coverage   36.34%   36.26%   -0.09%     
==========================================
  Files        3208     3208              
  Lines       93271    93276       +5     
  Branches    16836    16836              
==========================================
- Hits        33900    33822      -78     
- Misses      56942    57064     +122     
+ Partials     2429     2390      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details365d989c-2309-4ec9-9994-804f00bd6578

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant