-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-26778] Make VaultTimeoutService use LogoutService #16820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16820 +/- ##
==========================================
- Coverage 38.86% 38.86% -0.01%
==========================================
Files 3420 3420
Lines 97312 97311 -1
Branches 14625 14623 -2
==========================================
- Hits 37822 37820 -2
Misses 57835 57835
- Partials 1655 1656 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26778
📔 Objective
Moves logout logic out from vault timeout service and removes it as public API.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes