Skip to content

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Oct 10, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26778

📔 Objective

Moves logout logic out from vault timeout service and removes it as public API.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsc70cb747-5229-49c5-9c1e-d21310f6610f

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten changed the title Make vaulttimeoutservice use logoutservice [PM-26778] Make vaulttimeoutservice use logoutservice Oct 10, 2025
Copy link

@quexten quexten marked this pull request as ready for review October 10, 2025 10:49
@quexten quexten requested a review from a team as a code owner October 10, 2025 10:49
@quexten quexten requested a review from Thomas-Avery October 10, 2025 10:49
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.86%. Comparing base (e9cd6d2) to head (ff143a1).

Files with missing lines Patch % Lines
apps/browser/src/background/idle.background.ts 0.00% 2 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16820      +/-   ##
==========================================
- Coverage   38.86%   38.86%   -0.01%     
==========================================
  Files        3420     3420              
  Lines       97312    97311       -1     
  Branches    14625    14623       -2     
==========================================
- Hits        37822    37820       -2     
  Misses      57835    57835              
- Partials     1655     1656       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 10, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 10, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@quexten quexten changed the title [PM-26778] Make vaulttimeoutservice use logoutservice [PM-26778] Make VaultTimeoutService use LogoutService Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant