-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-24033]Implement Subscription Settings UI with Premium and Families Cards #16822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-24033]Implement Subscription Settings UI with Premium and Families Cards #16822
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16822 +/- ##
==========================================
+ Coverage 38.86% 38.89% +0.03%
==========================================
Files 3420 3436 +16
Lines 97312 97561 +249
Branches 14625 14673 +48
==========================================
+ Hits 37822 37951 +129
- Misses 57835 57951 +116
- Partials 1655 1659 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyprain-okeke overall looks great! For the "You have the Bitwarden Free plan" badge, can you make sure it is using the component library secondary badge? Right now the screen recording it looks a bit larger than what is in Figma.
Could you also upload a screen recording showing the responsive behavior of the page? Similar to what Stephon did in this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI looks good - badge styling now looks as expected in the responsive recording, and the responsive behavior looks great! Thanks Cy 🎉
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24033
📔 Objective
This PR implements the subscription settings page redesign according to the Figma specifications, displaying subscription plan cards and payment modal functionality for users without Premium access through paid organizations or active individual subscriptions.
Acceptance Criteria ✅
GIVEN: ALL the following conditions are met:
✅ User is not granted Premium through a paid organization
✅ User has no active individual Premium subscription
✅ User is viewing Settings > Subscription in the web app
THEN: The implementation provides:
✅ Figma design implementation with Free, Premium, and Families cards displayed
✅ Modal launch functionality for Premium and Families card selection
✅ Payment information form within the modal
📸 Screenshots
Screen.Recording.2025-10-10.at.1.03.06.PM.mov
Screen.Recording.2025-10-10.at.1.01.06.PM.mov
Responsive Recording
Screen.Recording.2025-10-13.at.1.10.15.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes