Skip to content

Conversation

neuronull
Copy link
Contributor

@neuronull neuronull commented Oct 10, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26792

📔 Objective

Currently any log::Record s are dropped. This change sets LogTracer as the global logger so that the log::Records are consumed and output as tracing Events, which we will pick up in our existing subscriber.

NOTE: this PR requires the following to be merged in first:

, as there can be no other log logger initialized.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@neuronull neuronull self-assigned this Oct 10, 2025
@neuronull neuronull requested a review from coroiu October 10, 2025 17:03
Copy link

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Logo
Checkmarx One – Scan Summary & Details0acce7ef-4677-4abe-bc82-c190a7943e4f

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.87%. Comparing base (9c7d794) to head (64e24f2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/desktop/desktop_native/napi/src/lib.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16827   +/-   ##
=======================================
  Coverage   38.86%   38.87%           
=======================================
  Files        3420     3420           
  Lines       97312    97318    +6     
  Branches    14625    14625           
=======================================
+ Hits        37822    37830    +8     
+ Misses      57835    57832    -3     
- Partials     1655     1656    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neuronull neuronull added the hold do not merge, do not approve yet label Oct 10, 2025
@coroiu coroiu removed their request for review October 13, 2025 07:21
@coroiu
Copy link
Contributor

coroiu commented Oct 13, 2025

Removing myself as reviewer while we wait for the other PRs (otherwise I'll get pinged about this twice a day 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold do not merge, do not approve yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants