Skip to content

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…e-custom-dialog-support' into ac/pm-26369-Add-Auto-Confirm-policy-to-client-domain-models
…Component' into ac/pm-26369-Add-Auto-Confirm-policy-to-client-domain-models
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsda2d7760-6557-4d42-a701-2be16f7b138d

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.88%. Comparing base (c58f778) to head (05c804c).

Files with missing lines Patch % Lines
...-edit-definitions/auto-confirm-policy.component.ts 60.00% 10 Missing ⚠️
...icies/auto-confirm-edit-policy-dialog.component.ts 12.50% 7 Missing ⚠️
...nsole/organizations/policies/policies.component.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                          @@
##           ac/pm-26362-Create-multi-step-Auto-Confirm-Edit-Policy-Component   #16830      +/-   ##
====================================================================================================
+ Coverage                                                             38.84%   38.88%   +0.03%     
====================================================================================================
  Files                                                                  3421     3422       +1     
  Lines                                                                 97378    97413      +35     
  Branches                                                              14632    14631       -1     
====================================================================================================
+ Hits                                                                  37831    37877      +46     
+ Misses                                                                57891    57880      -11     
  Partials                                                               1656     1656              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant