Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Dec 26, 2025

🎟️ Tracking

[Ticket pending, will add before merge]

📔 Objective

QA found some more cases for where the agent crashes during testing of the previous fixes. Tracking these down, they specifically occur on login because the cipher service does not yet have ciphers loaded. This PR changes the observable to just wait for ciphers to be available. Further, there is a case of the active account value being null, and the ID being accessed on this null value.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as ready for review December 26, 2025 21:03
@quexten quexten requested a review from a team as a code owner December 26, 2025 21:03
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7cb5eaf3-2124-4ef6-90e2-153f7d5e1914

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.27%. Comparing base (99305a5) to head (c7c42a3).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...desktop/src/autofill/services/ssh-agent.service.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18123      +/-   ##
==========================================
- Coverage   42.27%   42.27%   -0.01%     
==========================================
  Files        3592     3592              
  Lines      104325   104326       +1     
  Branches    15734    15737       +3     
==========================================
- Hits        44107    44102       -5     
- Misses      58342    58349       +7     
+ Partials     1876     1875       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@neuronull neuronull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA found some more cases for where the agent crashes during testing of the previous fixes.

🤔 did QA find a problem with a prior commit after it was merged? Looking to understand if this was a regression from a prior fix or if it's something exposed by the other fix but was already there, or something else.

(I saw the jira ticket is pending so that might contain the info to help understand the story.)

Separately (not asking for the changes in this PR) but- I'm wondering if this is something that could be unit testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants