Skip to content

Conversation

@majiayu000
Copy link

Summary

  • Handle url field case-insensitively (URL, url, Url)
  • Map note field to cipher notes
  • Add !type to official props to exclude from custom fields
  • Only add non-empty custom fields

Fixes #17119

Test plan

  • Import a Buttercup CSV export with url (lowercase) field
  • Verify URL is correctly imported to login URIs
  • Import with note field
  • Verify notes are correctly imported
  • Verify !type, !group_id, id fields are not added as custom fields

- Handle url field case-insensitively (URL, url, Url)
- Map note field to cipher notes
- Add !type to official props to exclude from custom fields
- Only add non-empty custom fields
- Add comprehensive unit tests

Fixes bitwarden#17119

Signed-off-by: majiayu000 <[email protected]>
@majiayu000 majiayu000 requested a review from a team as a code owner December 29, 2025 03:19
@CLAassistant
Copy link

CLAassistant commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-30266
Link: https://bitwarden.atlassian.net/browse/PM-30266

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title fix(importer): improve Buttercup CSV import mapping [PM-30266] fix(importer): improve Buttercup CSV import mapping Dec 29, 2025
@bitwarden-bot bitwarden-bot added community-pr needs-qa Marks a PR as requiring QA approval labels Dec 29, 2025
@harr1424
Copy link
Contributor

harr1424 commented Dec 29, 2025

Hi @majiayu000 👋 !

Thanks for your contribution, and especially for providing thorough test coverage. This link describes the process that your contribution will undergo before becoming a part of the Bitwarden codebase. Please keep in mind that your submission will be reviewed by Bitwarden's product and engineering teams before an official code review happens on Github. Since this review process occurs internally, it may seem as though little progress is taking place.

We understand many former Buttercup users have migrated to Bitwarden, and are very grateful for the improved support your PR will provide. Thank you for your patience throughout the review process, and please feel free to check in at anytime by tagging me here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-pr needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Buttercup CSV import mapping

4 participants