Skip to content

Conversation

@majiayu000
Copy link

Summary

  • Protected fields (ProtectInMemory="True") are now always imported as hidden custom fields
  • Previously, long (>200 chars) or multiline protected fields were appended to notes instead

Fixes #16897

Test plan

  • Import KeePass V2 XML with protected custom fields
  • Verify protected fields appear as hidden custom fields (not in notes)
  • Verify this works for short, long, and multiline protected values

Protected fields (ProtectInMemory="True") were being appended to notes
when they exceeded 200 characters or contained newlines, instead of
being imported as hidden custom fields.

Now protected fields are always imported as hidden fields regardless
of their length or content, preserving their protected status.

Fixes bitwarden#16897

Signed-off-by: majiayu000 <[email protected]>
@majiayu000 majiayu000 requested a review from a team as a code owner December 29, 2025 03:25
@CLAassistant
Copy link

CLAassistant commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-30267
Link: https://bitwarden.atlassian.net/browse/PM-30267

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title fix(importer): preserve protected KeePass custom fields as hidden fields [PM-30267] fix(importer): preserve protected KeePass custom fields as hidden fields Dec 29, 2025
@bitwarden-bot bitwarden-bot added community-pr needs-qa Marks a PR as requiring QA approval labels Dec 29, 2025
@harr1424
Copy link
Contributor

Hi @majiayu000 👋 !

Thanks for another valuable contribution!

This link describes](https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process/) the process that your contribution will undergo before becoming a part of the Bitwarden codebase. Please keep in mind that your submission will be reviewed by Bitwarden's product and engineering teams before an official code review happens on Github. Since this review process occurs internally, it may seem as though little progress is taking place.

Thank you for your patience throughout the review process, and please feel free to check in at anytime by tagging me here.

@majiayu000
Copy link
Author

Thanks for the update! I understand the process and will be patient. Feel free to reach out if you need any changes or have questions about the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-pr needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import of Keepass v2 XML unhides protected fields and merges them into "Additional Options"

4 participants