-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add CI validations install and run Desktop client (Windows) #18141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: autofill/pm-30131/add-ci-workflow-install-run-desktop-client
Are you sure you want to change the base?
Conversation
|
New Issues (5)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## autofill/pm-30131/add-ci-workflow-install-run-desktop-client #18141 +/- ##
================================================================================================
- Coverage 42.27% 42.27% -0.01%
================================================================================================
Files 3592 3592
Lines 104325 104325
Branches 15734 15734
================================================================================================
- Hits 44105 44104 -1
Misses 58345 58345
- Partials 1875 1876 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a413a6 to
6ad6cb8
Compare
|





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30132
📔 Objective
Adds validation step to install the Windows portable for Desktop, and run the client. The new check provides automated confirmation that what we built and packaged is installable and does not crash when executed on the Windows platform.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes