Skip to content

Conversation

@bmbitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29917

📔 Objective

Split the send access component in the web project into multiple components

📸 Screenshots

Screenshot 2025-12-29 at 1 01 59 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bmbitwarden bmbitwarden requested a review from a team as a code owner December 29, 2025 18:16
@bmbitwarden bmbitwarden added the needs-qa Marks a PR as requiring QA approval label Dec 29, 2025
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0c359581-c802-4114-9800-fa06ee016784

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.25%. Comparing base (1c16b8e) to head (9b47133).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../app/tools/send/send-access/send-view.component.ts 0.00% 64 Missing ⚠️
.../app/tools/send/send-access/send-auth.component.ts 0.00% 41 Missing ⚠️
...src/app/tools/send/send-access/access.component.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18142      +/-   ##
==========================================
- Coverage   42.26%   42.25%   -0.02%     
==========================================
  Files        3592     3594       +2     
  Lines      104315   104363      +48     
  Branches    15733    15736       +3     
==========================================
+ Hits        44093    44099       +6     
- Misses      58348    58389      +41     
- Partials     1874     1875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harr1424 harr1424 added the ai-review Request a Claude code review label Dec 29, 2025
@bmbitwarden bmbitwarden removed the ai-review Request a Claude code review label Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants