Skip to content

Conversation

@sbrown-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29906

📔 Objective

Fix the Secrets Manager defect, update display logic, and remove stale dependencies.

📸 Screenshots

Screen.Recording.2025-12-29.at.5.11.00.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

await this.load();
}

calculateTotalAppliedDiscount(total: number) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I'm not misinterpreting this, right? We were trying to calculate the original price using the discounted total. Can't we just use an originalAmount property?

@sbrown-livefront sbrown-livefront marked this pull request as ready for review December 29, 2025 22:16
@sbrown-livefront sbrown-livefront requested a review from a team as a code owner December 29, 2025 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Logo
Checkmarx One – Scan Summary & Detailseeef334b-d734-4247-984a-a39e9fffac5f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.24%. Comparing base (cf1c322) to head (76fb755).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18147   +/-   ##
=======================================
  Coverage   42.24%   42.24%           
=======================================
  Files        3598     3598           
  Lines      104474   104469    -5     
  Branches    15763    15762    -1     
=======================================
  Hits        44135    44135           
+ Misses      58461    58456    -5     
  Partials     1878     1878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants