[PM-30307] incorrectly serialized symmetric crypto key in session storage

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30307

📔 Objective

Attempting to decrypt any item using session key fails with error: The cipher's MAC doesn't match the expected value.
This is due to incorrectly serialized symmetric crypto key, which is expected to be read from storage as JSON serialized B64 string, but it's not.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – daf46e89-2c23-49c8-bb14-4fc31ef9743e

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 42.23%. Comparing base (cf1c322) to head (16beb09).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/browser/src/background/main.background.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18150      +/-   ##
==========================================
- Coverage   42.24%   42.23%   -0.01%     
==========================================
  Files        3598     3598              
  Lines      104474   104474              
  Branches    15763    15763              
==========================================
- Hits        44135    44127       -8     
- Misses      58461    58468       +7     
- Partials     1878     1879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉