[PM-29518] Remove @ts-strict-ignore in overlay/inline-menu/content/autofill-inline-menu-content.service.ts

[dan-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29518

📔 Objective

• Initialized observers directly in the constructor
• Explicitly initialized timers as null to clarify lifecycle and avoid undefined states
• Removed redundant checks for inlineMenuEnabled
• Explicitly tracked the inline menu button and list so TypeScript can treat them as definitely assigned
• Added early returns in processContainerElementMutation for clearer control flow
  • initially I had tracked the button and list component which would be passed as a param in order to avoid early returns and handle these concerns higher up for a better contract but that caused noticeable performance issues in the inline menu rendering.
• Added a fallback of 0 when accessing lastChild index if it is undefined

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – ffc0c89b-e32d-46ca-939c-59ef176be0c7

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.25%. Comparing base (11b5342) to head (b8963c6).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...nu/content/autofill-inline-menu-content.service.ts	78.94%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18155      +/-   ##
==========================================
- Coverage   42.26%   42.25%   -0.01%     
==========================================
  Files        3599     3599              
  Lines      104516   104515       -1     
  Branches    15776    15775       -1     
==========================================
- Hits        44171    44166       -5     
- Misses      58465    58468       +3     
- Partials     1880     1881       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉