Skip to content

Conversation

@BryanCunningham
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-947

📔 Objective

Adds ability to configure drawer size

📸 Screenshots

small

image

default

image

large

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BryanCunningham BryanCunningham requested a review from a team as a code owner December 30, 2025 21:17
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse4938922-8e3e-4eb5-9619-a3691630a6c0

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.24%. Comparing base (cf1c322) to head (d1f24c0).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bs/components/src/dialog/dialog.service.stories.ts 0.00% 20 Missing ⚠️
...s/components/src/dialog/dialog/dialog.component.ts 33.33% 2 Missing ⚠️
...s/components/src/dialog/get-dialog-width-styles.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18156   +/-   ##
=======================================
  Coverage   42.24%   42.24%           
=======================================
  Files        3598     3600    +2     
  Lines      104474   104538   +64     
  Branches    15763    15779   +16     
=======================================
+ Hits        44135    44166   +31     
- Misses      58461    58491   +30     
- Partials     1878     1881    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants