Skip to content

change tap to mergeMap #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

change tap to mergeMap #9083

wants to merge 1 commit into from

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented May 8, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Changes the tap in the browser popup for message handling to be a mergeMap. This is how we're handling it in the background and allows for async execution of messages.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@jlf0dev jlf0dev requested a review from justindbaur May 8, 2024 13:18
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 27.63%. Comparing base (5682e38) to head (3300028).

Files Patch % Lines
apps/browser/src/popup/app.component.ts 0.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9083      +/-   ##
==========================================
- Coverage   27.63%   27.63%   -0.01%     
==========================================
  Files        2416     2416              
  Lines       69875    69880       +5     
  Branches    13012    13013       +1     
==========================================
  Hits        19309    19309              
- Misses      49067    49072       +5     
  Partials     1499     1499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 8, 2024

Logo
Checkmarx One – Scan Summary & Details6baa4c8e-585f-4d34-9121-c022d6fb868c

No New Or Fixed Issues Found

@trmartin4 trmartin4 marked this pull request as draft May 31, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant