-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-6271] Propose cipher versioning with migration in data layer #9337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
coroiu
wants to merge
10
commits into
main
Choose a base branch
from
PM-6271-propose-cipher-versioning-scheme-data-layer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will not compile because the connection between data -> domain is not yet implemented here.
The cipher service is still not properly implemented in this commit. This commit does not actually implement the migration algorithm.
No more build errors. Just need to implement migration in CipherData
New Issues
Fixed Issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR contains a proof of concept for the "Data layer" approach described here: https://bitwarden.atlassian.net/wiki/spaces/~62955327d9eae9006f348ae9/pages/944701442/Proof+of+concept+Cipher+versioning#Data-%E2%80%9Clayer%E2%80%9D
Code changes
The PR contains a lot of changes, but most are either import path changes or duplicate boilerplate code.
The important parts are:
API Layer
versions of ciphers in the api layer. These are used by both responses and requests
Data Layer
versions of ciphers in the data layer.
Cipher Service
Before you submit