Skip to content

[PM-11855] Remove unused jslib code - #1013

Merged
BTreston merged 49 commits into
mainfrom
jslib-removal
Apr 6, 2026
Merged

[PM-11855] Remove unused jslib code#1013
BTreston merged 49 commits into
mainfrom
jslib-removal

Conversation

@BTreston

@BTreston BTreston commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-11855

📔 Objective

Removes most of the unused jslib code baggage. There is still room for improvement here down the road (referencing specifically the PlatformUtilsService) however this amount of cleanup will more than suffice for the current modernization effort.

📸 Screenshots

@codecov

codecov Bot commented Feb 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.47%. Comparing base (5e32170) to head (72335da).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/services.module.ts 0.00% 1 Missing ⚠️
src/services/sync.service.integration.spec.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5e32170) and HEAD (72335da). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (5e32170) HEAD (72335da)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   25.41%   17.47%   -7.95%     
==========================================
  Files          73       73              
  Lines        2935     2936       +1     
  Branches      528      528              
==========================================
- Hits          746      513     -233     
- Misses       2069     2375     +306     
+ Partials      120       48      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details61497082-1428-4778-9cce-916a147998fa


New Issues (2) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Use_Of_Hardcoded_Password /src/services/state-service/default-state.service.spec.ts: 63
detailsThe application uses the hard-coded password "secret-password" for authentication purposes, either using it to verify users' identities, or to ac...
Attack Vector
2 MEDIUM Use_Of_Hardcoded_Password /utils/openldap/config-fixtures.ts: 21
detailsThe application uses the hard-coded password "admin" for authentication purposes, either using it to verify users' identities, or to access anothe...
Attack Vector

@BTreston
BTreston changed the base branch from dev-clarity-hands-on to ac/pm-31159-state-service March 4, 2026 21:39
@BTreston BTreston changed the title remove unused jslib code [PM-11855] Remove unused jslib code Mar 5, 2026
BTreston added 20 commits March 11, 2026 15:42
- State v4 was never properly migrated, handle migration directly from v3
- fix access token not properly migrated
- fix environment urls not properly migrated
- update tests
- fix fresh install (missing state version) being set to v1 -> v5 (current)
- Rename state.service.ts to default-state.service.ts
- Rename state.service.spec.ts to default-state.service.spec.ts
- Clean up state service interface to remove unused StorageOptions
- More type saftey for storage keys
- Clean up migration logic
Base automatically changed from ac/pm-31159-state-service to main April 6, 2026 18:36
@BTreston
BTreston marked this pull request as ready for review April 6, 2026 18:50
@BTreston
BTreston requested a review from a team as a code owner April 6, 2026 18:50
@BTreston
BTreston requested a review from r-tome April 6, 2026 18:50
@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@BTreston
BTreston requested a review from eliykat April 6, 2026 19:54
@BTreston
BTreston merged commit 532e2fa into main Apr 6, 2026
27 of 28 checks passed
@BTreston
BTreston deleted the jslib-removal branch April 6, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants