[PM-11854] Add latest tools from template repo - #1050
Conversation
…t formatting - Added a new .cspell.json file for spell checking configuration. - Updated .editorconfig to enforce consistent indentation and formatting rules across various file types. - Simplified .gitattributes to set default text normalization behavior. - Revised CONTRIBUTING.md to direct users to updated contribution guidelines. - Removed outdated ISSUE_TEMPLATE.md. - Enhanced SECURITY.md for better readability. - Updated renovate.json5 to include docker-compose in enabled managers. - Modified scan.yml to include additional branches for CI workflows.
|
Claude finished @JaredScar's task in 2m 1s —— View job Code Review: PR #1050 — PM-11854 Add latest tools from template repo
SummaryThis is a clean infrastructure/configuration PR that modernizes the repo by pulling in tooling from the Bitwarden template repo. No actionable findings — no bugs, security issues, or concerns. All changes are limited to config, CI, and documentation — no application code is touched:
Prior Review Feedback — AddressedThe latest commits address the two items previously flagged by @r-tome:
VerdictStraightforward modernization changes aligned with the template repo. Looks good to merge. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
|
Claude picked up on these:
DC's
The template uses "./!(jslib)**": "prettier --cache --ignore-unknown --write", |
|
@JaredScar pls address the linter errors. TY |
…uration - Changed the husky preparation script from "husky install" to "husky". - Updated lint-staged configuration to use "prettier --cache" for improved performance.
theMickster
left a comment
theMickster
left a comment
There was a problem hiding this comment.
Approving the Claude changes. The rest are left to the team
…ype consistency - Deleted the .cspell.json file as it is no longer needed. - Updated .editorconfig to include 'cjs' and 'mjs' file types and changed 'scss' to 'css' for better consistency.
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR modernizes the directory-connector repository by aligning configuration and tooling files with the Bitwarden template repo. Changes are limited to editor config, Renovate config, CI workflow triggers, Prettier settings, Husky script syntax, and documentation files. No application code is modified. Previous reviewer feedback from resolved threads (npm minor grouping removal, cspell removal) has been addressed. Code Review DetailsNo findings. All changes are configuration and documentation updates with no impact on runtime behavior. The Husky prepare script correctly uses Husky 9 syntax, and the scan workflow now covers |
… and performance - Reformatted ESLint configuration for better readability. - Updated Jest configuration to ensure proper test coverage and environment settings. - Adjusted Webpack configurations for CLI and main renderer to align with new directory structure. - Refactored SCSS font-face definitions for consistency in styling.
… into ac/pm-11854-add-useful-tools-from-template-repo
…ed readability - Adjusted formatting in CLAUDE.md for clearer import pattern definitions. - Reformatted .github/renovate.json5 for better structure and consistency.
|
6 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11854
📔 Objective
Aims to modernize the DC repo to add useful tools from the template repo here.