Skip to content

Allow customer-only Google Workspace config - #1194

Open
watchingdogs wants to merge 2 commits into
bitwarden:mainfrom
watchingdogs:fix/gsuite-customer-only-config
Open

Allow customer-only Google Workspace config#1194
watchingdogs wants to merge 2 commits into
bitwarden:mainfrom
watchingdogs:fix/gsuite-customer-only-config

Conversation

@watchingdogs

Copy link
Copy Markdown

🎟️ Tracking

ID: PM-40799
Link: https://bitwarden.atlassian.net/browse/PM-40799
Issue: #1193

📔 Objective

Allow a Google Workspace configuration with only Customer ID set, currently rejected as "Directory configuration incomplete", which leaves multi-domain accounts unable to sync all of their domains (see the linked issue for details).

  • Validation now requires at least one of domain / customer.
  • Exactly one query parameter is sent per request; domain keeps precedence when both are configured, so existing configurations keep their current sync scope, the change is purely additive.
  • A whitespace-only domain no longer results in a parameterless request (previously surfaced as an obscure Directory API error).

Unit tests added for the validation and parameter selection. Verified against a live multi-domain tenant (8 users, 2 groups, one secondary domain):

Config Before After
customer only rejected 8 users, 2 groups
domain + customer 7 / 1 7 / 1 (unchanged)
domain only 7 / 1 7 / 1 (unchanged)

@watchingdogs
watchingdogs requested a review from a team as a code owner July 22, 2026 20:32
@watchingdogs
watchingdogs requested a review from eliykat July 22, 2026 20:32
@CLAassistant

CLAassistant commented Jul 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot

Copy link
Copy Markdown

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-40802
Link: https://bitwarden.atlassian.net/browse/PM-40802

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@eliykat

eliykat commented Jul 23, 2026

Copy link
Copy Markdown
Member

Thanks for your PR @watchingdogs . Your issue write-up and proposed solution make sense to me, but I'm just double checking internally as I'm less familiar with the Google API specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants