Allow customer-only Google Workspace config - #1194
Open
watchingdogs wants to merge 2 commits into
Open
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Member
|
Thanks for your PR @watchingdogs . Your issue write-up and proposed solution make sense to me, but I'm just double checking internally as I'm less familiar with the Google API specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
ID: PM-40799
Link: https://bitwarden.atlassian.net/browse/PM-40799
Issue: #1193
📔 Objective
Allow a Google Workspace configuration with only
Customer IDset, currently rejected as "Directory configuration incomplete", which leaves multi-domain accounts unable to sync all of their domains (see the linked issue for details).domain/customer.domainkeeps precedence when both are configured, so existing configurations keep their current sync scope, the change is purely additive.domainno longer results in a parameterless request (previously surfaced as an obscure Directory API error).Unit tests added for the validation and parameter selection. Verified against a live multi-domain tenant (8 users, 2 groups, one secondary domain):