Skip to content
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ClientType } from "../../../enums/clientType";
Comment thread
BTreston marked this conversation as resolved.
import { Utils } from "../../../misc/utils";
import { CaptchaProtectedRequest } from "../captchaProtectedRequest";
Comment thread
BTreston marked this conversation as resolved.
import { DeviceRequest } from "../deviceRequest";

Expand Down Expand Up @@ -30,5 +29,4 @@ export class PasswordTokenRequest extends TokenRequest implements CaptchaProtect

return obj;
}

}
3 changes: 1 addition & 2 deletions jslib/common/src/services/state.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ const partialKeys = {
export class StateService<
TGlobalState extends GlobalState = GlobalState,
TAccount extends Account = Account,
> implements StateServiceAbstraction<TAccount>
{
> implements StateServiceAbstraction<TAccount> {
Comment thread
BTreston marked this conversation as resolved.
Comment thread
BTreston marked this conversation as resolved.
protected accountsSubject = new BehaviorSubject<{ [userId: string]: TAccount }>({});
accounts$ = this.accountsSubject.asObservable();

Expand Down
6 changes: 5 additions & 1 deletion jslib/node/src/cli/commands/update.command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ export class UpdateCommand {
"https://api.github.com/repos/bitwarden/" + this.repoName + "/releases/latest",
);
if (response.status === 200) {
const responseJson = await response.json();
// FIXME As of node-fetch v.3 this response has "unknown" type.
// Github provides type definitions for thier public api,
Comment thread
BTreston marked this conversation as resolved.
Outdated
// but as of now we do not have them as a dependnecy. We
// should in the future consider adding this.
const responseJson = (await response.json()) as any;
Comment thread
BTreston marked this conversation as resolved.
Outdated
Comment thread
BTreston marked this conversation as resolved.
Outdated
const res = new MessageResponse(null, null);

const tagName: string = responseJson.tag_name;
Expand Down
207 changes: 172 additions & 35 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
"ldapts": "8.0.1",
"lowdb": "1.0.0",
"ngx-toastr": "19.1.0",
"node-fetch": "2.7.0",
"node-fetch": "3.3.2",
Comment thread
BTreston marked this conversation as resolved.
"parse5": "8.0.0",
"proper-lockfile": "4.1.2",
"rxjs": "7.8.2",
Expand Down
Loading