-
Notifications
You must be signed in to change notification settings - Fork 99
Implement reusable Claude code review workflow #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
theMickster
merged 5 commits into
main
from
arch/pm-26935/reusable-code-review-workflow
Oct 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
be7ad1d
Implement reusable Claude code review workflow
theMickster 16aef70
Suggested claude.md changes
eliykat 208cb3a
Focus more on project structure than code review guidelines
eliykat 2550c97
Merge branch 'main' into arch/pm-26935/reusable-code-review-workflow
eliykat bd9aae2
Set claude related file code ownership
theMickster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Bitwarden Directory Connector | ||
|
|
||
| ## References | ||
|
|
||
| - [Architectural Decision Records (ADRs)](https://contributing.bitwarden.com/architecture/adr/) | ||
| - [Contributing Guidelines](https://contributing.bitwarden.com/contributing/) | ||
| - [Code Style](https://contributing.bitwarden.com/contributing/code-style/) | ||
| - [Security Whitepaper](https://bitwarden.com/help/bitwarden-security-white-paper/) | ||
| - [Security Definitions](https://contributing.bitwarden.com/architecture/security/definitions) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| Please review this pull request with a focus on: | ||
|
|
||
| - Code quality and best practices | ||
| - Potential bugs or issues | ||
| - Security implications | ||
| - Performance considerations | ||
|
|
||
| Note: The PR branch is already checked out in the current working directory. | ||
|
|
||
| Provide a comprehensive review including: | ||
|
|
||
| - Summary of changes since last review | ||
| - Critical issues found (be thorough) | ||
| - Suggested improvements (be thorough) | ||
| - Good practices observed (be concise - list only the most notable items without elaboration) | ||
| - Action items for the author | ||
| - Leverage collapsible <details> sections where appropriate for lengthy explanations or code | ||
| snippets to enhance human readability | ||
|
|
||
| When reviewing subsequent commits: | ||
|
|
||
| - Track status of previously identified issues (fixed/unfixed/reopened) | ||
| - Identify NEW problems introduced since last review | ||
| - Note if fixes introduced new issues | ||
|
|
||
| IMPORTANT: Be comprehensive about issues and improvements. For good practices, be brief - just note | ||
| what was done well without explaining why or praising excessively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Respond | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| issues: | ||
| types: [opened, assigned] | ||
| pull_request_review: | ||
| types: [submitted] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| respond: | ||
| name: Respond | ||
| uses: bitwarden/gh-actions/.github/workflows/_respond.yml@main | ||
| secrets: | ||
| AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} | ||
| AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} | ||
| AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }} | ||
| permissions: | ||
| actions: read | ||
| contents: write | ||
| id-token: write | ||
| issues: write | ||
| pull-requests: write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Code Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| review: | ||
| name: Review | ||
| uses: bitwarden/gh-actions/.github/workflows/_review-code.yml@main | ||
| secrets: | ||
| AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} | ||
| AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} | ||
| AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }} | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| pull-requests: write |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.