Skip to content

[BRE-1670] Replace PAT tokens with bot token#263

Merged
AmyLGalles merged 6 commits into
mainfrom
agalles/BRE-1670-2
Apr 20, 2026
Merged

[BRE-1670] Replace PAT tokens with bot token#263
AmyLGalles merged 6 commits into
mainfrom
agalles/BRE-1670-2

Conversation

@AmyLGalles
Copy link
Copy Markdown
Contributor

@AmyLGalles AmyLGalles commented Apr 9, 2026

🎟️ Tracking

BRE-1670

📔 Objective

Updating github workflows that use PAT to use app token or GITHUB_TOKEN instead.

In some cases, the PAT token was being used for simple repo actions that didn't require further authentication, such as reading from or cloning a public repository.

GPG signing with the app token requires use of the gh API which is why there are changes to the checkout script

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner April 9, 2026 17:41
@AmyLGalles AmyLGalles changed the title replace PAT tokens with bot token BRE-1670 Replace PAT tokens with bot token Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

Logo
Checkmarx One – Scan Summary & Detailsf1446893-4818-480c-a524-17734e0fa087

Great job! No new security vulnerabilities introduced in this pull request

@AmyLGalles AmyLGalles changed the title BRE-1670 Replace PAT tokens with bot token [BRE-1670] Replace PAT tokens with bot token Apr 9, 2026
@AmyLGalles AmyLGalles marked this pull request as draft April 9, 2026 18:39
@AmyLGalles AmyLGalles marked this pull request as ready for review April 9, 2026 21:25
Comment thread .github/workflows/fdroid.yml Outdated
Co-authored-by: Patrick Honkonen <1883101+SaintPatrck@users.noreply.github.com>
@AmyLGalles AmyLGalles requested a review from SaintPatrck April 14, 2026 23:20
@vgrassia vgrassia added the ai-review Request a Claude code review label Apr 14, 2026
@AmyLGalles AmyLGalles marked this pull request as draft April 15, 2026 07:07
@AmyLGalles AmyLGalles marked this pull request as ready for review April 15, 2026 07:07
@AmyLGalles
Copy link
Copy Markdown
Contributor Author

@claude review this

@sonarqubecloud
Copy link
Copy Markdown

@AmyLGalles AmyLGalles enabled auto-merge (squash) April 16, 2026 19:01
@AmyLGalles
Copy link
Copy Markdown
Contributor Author

@SaintPatrck could you give me some 👀 on this?

@AmyLGalles AmyLGalles merged commit f5ae484 into main Apr 20, 2026
7 checks passed
@AmyLGalles AmyLGalles deleted the agalles/BRE-1670-2 branch April 20, 2026 15:00
vvolkgang added a commit that referenced this pull request May 20, 2026
#271)

This reverts the update_repo.sh changes from commit f5ae484.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants