Skip to content

[PM-27140] feat: Add File Share view to Test Harness app.#2778

Merged
morganzellers-bw merged 14 commits into
mainfrom
morgan/pm-27140-testharness-file-share-view
Jun 18, 2026
Merged

[PM-27140] feat: Add File Share view to Test Harness app.#2778
morganzellers-bw merged 14 commits into
mainfrom
morgan/pm-27140-testharness-file-share-view

Conversation

@morganzellers-bw

@morganzellers-bw morganzellers-bw commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27140

📔 Objective

Adds a view to the Test Harness app where the Bitwarden Share feature can be tested.

📸 Screenshots

Expand Simulator Screenshot - iPhone 17 Pro - 2026-06-10 at 12 23 55

@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jun 10, 2026
@morganzellers-bw morganzellers-bw changed the title Adds first pass on totp view. [PM-27140] feat: Add File Share view to Test Harness app. Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (6f8490c) to head (b2463b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2778      +/-   ##
==========================================
- Coverage   80.81%   78.56%   -2.26%     
==========================================
  Files        1019     1142     +123     
  Lines       64912    72208    +7296     
==========================================
+ Hits        52460    56730    +4270     
- Misses      12452    15478    +3026     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morganzellers-bw morganzellers-bw marked this pull request as ready for review June 10, 2026 22:01
@morganzellers-bw morganzellers-bw requested review from a team and matt-livefront as code owners June 10, 2026 22:01
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of a FileShare test scenario to the Test Harness app: a new FileShareAction/Effect/State/Processor/View quintet under TestHarnessShared/UI/Tools/FileShare/, wiring through RootRoute.fileShare, RootCoordinator.showFileShare(), and ScenarioPickerState, plus a localized strings update that renames SimpleLoginFormDescription to UseThisLoginFormToTestAutofillFunctionality. The new screen exercises text, file, and image share paths via iOS 16+ ShareLink/Transferable. The implementation follows the existing SimpleLoginForm/CardAutofillForm patterns exactly, uses the canonical UI/Tools/ subdirectory, gates iOS 16-only APIs consistently, and includes processor unit tests covering initial state, the text-content action, and the viewAppeared effect.

Code Review Details

No findings. Architecture, availability gating, localization handling, and test coverage all align with existing test-harness conventions.

@fedemkr fedemkr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor improvements. Btw really like the approach of generating the files to share 🚀

Comment thread TestHarnessShared/UI/Tools/FileShare/FileShareState.swift Outdated
Comment thread TestHarnessShared/UI/Tools/FileShare/FileShareView.swift
@morganzellers-bw morganzellers-bw force-pushed the morgan/pm-27140-testharness-file-share-view branch from 36c6984 to ad7b029 Compare June 16, 2026 18:46
@morganzellers-bw morganzellers-bw requested a review from fedemkr June 16, 2026 20:52
@morganzellers-bw morganzellers-bw merged commit d83e7cb into main Jun 18, 2026
22 checks passed
@morganzellers-bw morganzellers-bw deleted the morgan/pm-27140-testharness-file-share-view branch June 18, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants