Skip to content

[PM-26960] chore: Remove forceUpdateKdfSettings feature flag#2799

Merged
matt-livefront merged 1 commit into
mainfrom
matt/PM-26960-remove-update-kdf-ff
Jun 17, 2026
Merged

[PM-26960] chore: Remove forceUpdateKdfSettings feature flag#2799
matt-livefront merged 1 commit into
mainfrom
matt/PM-26960-remove-update-kdf-ff

Conversation

@matt-livefront

@matt-livefront matt-livefront commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-26960

📔 Objective

Removes the forceUpdateKdfSettings (pm-18021-force-update-kdf-settings) feature flag.

@matt-livefront matt-livefront added the ai-review Request a Claude code review label Jun 16, 2026
@matt-livefront matt-livefront requested a review from a team as a code owner June 16, 2026 19:04
@matt-livefront matt-livefront added the t:tech-debt Change Type - Tech debt label Jun 16, 2026
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the forceUpdateKdfSettings (pm-18021-force-update-kdf-settings) feature flag. The change removes the flag enum case and its CaseIterable entry, drops the two flag guards inside ChangeKdfService.needsKdfUpdateToMinimums() and updateKdfToMinimums(), and updates the DI wiring and tests accordingly. The behavior previously gated by the flag is now always enabled, which matches the intent of the flag removal; the underlying KDF eligibility guards (PBKDF2 type, iterations below minimum, master password present) remain intact, and no references to the removed flag remain in the codebase.

Code Review Details

No blocking findings.

Minor (non-blocking, not posted inline): the test docstring at BitwardenShared/Core/Auth/Services/ChangeKdfServiceTests.swift:121 still reads "returns true if the feature flag is on...", which is now stale since the flag is gone. Optional cleanup.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.82%. Comparing base (66a5f60) to head (9ff3dcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files        1019     1019              
  Lines       64854    64847       -7     
==========================================
+ Hits        52404    52412       +8     
+ Misses      12450    12435      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit f5067ec into main Jun 17, 2026
23 of 27 checks passed
@matt-livefront matt-livefront deleted the matt/PM-26960-remove-update-kdf-ff branch June 17, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants