[PM-13984] Added Futurex to list of supported PKCS #11 providers#187
[PM-13984] Added Futurex to list of supported PKCS #11 providers#187bbarrows-futurex wants to merge 4 commits into
Conversation
Added "futurex" to commented out list of pkcs11 providers.
Added Futurex PKCS bitwarden#11 library to libPath list
Added "futurex" to the list of available PKCS bitwarden#11 providers.
Added "futurex" to list of providers for tests
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
|
@bbarrows-futurex Apologies for the delay here. Could you please provide a description to your PR. This will help Product management to review and if approved passed on to Engineering. Kind regards, |
pixman20
left a comment
There was a problem hiding this comment.
Review Summary
PR: [PM-13984] Added Futurex to list of supported PKCS #11 providers
| Aspect | Assessment |
|---|---|
| Risk | Low |
| Type | Feature addition |
| Security | No concerns |
| Testing | Adequate - test cases added for both Decrypt and Sign paths |
Overview
Clean, well-structured community contribution that adds Futurex CryptoHub as a supported PKCS#11 HSM provider. All changes follow existing patterns exactly:
- README.md - Updated provider comment to include
futurex - KeyConnectorSettings.cs - Added
futurexto the provider comment list - Pkcs11RsaKeyService.cs - Added library path mapping in the
LoadLibraryswitch expression - Pkcs11RsaKeyServiceTests.cs - Added
InlineDatatest cases for bothDecryptAsyncandSignAsynclibrary path resolution
No issues found. The change is purely additive, follows established conventions, and includes appropriate test coverage.
Futurex and Bitwarden worked together to get the PKCS #11 integration working with the Futurex CryptoHub, and the documentation for it is published here:
https://docs.futurex.com/cryptohub-integration-guides/bitwarden
I don't know that code changes are required in this repository, but it would be great if Futurex could be included in any lists of supported HSMs for the integration.