Skip to content

[PM-13984] Added Futurex to list of supported PKCS #11 providers#187

Open
bbarrows-futurex wants to merge 4 commits into
bitwarden:mainfrom
bbarrows-futurex:main
Open

[PM-13984] Added Futurex to list of supported PKCS #11 providers#187
bbarrows-futurex wants to merge 4 commits into
bitwarden:mainfrom
bbarrows-futurex:main

Conversation

@bbarrows-futurex
Copy link
Copy Markdown

@bbarrows-futurex bbarrows-futurex commented Oct 23, 2024

Futurex and Bitwarden worked together to get the PKCS #11 integration working with the Futurex CryptoHub, and the documentation for it is published here:
https://docs.futurex.com/cryptohub-integration-guides/bitwarden

I don't know that code changes are required in this repository, but it would be great if Futurex could be included in any lists of supported HSMs for the integration.

Added "futurex" to commented out list of pkcs11 providers.
Added Futurex PKCS bitwarden#11 library to libPath list
Added "futurex" to the list of available PKCS bitwarden#11 providers.
Added "futurex" to list of providers for tests
@bbarrows-futurex bbarrows-futurex requested a review from a team as a code owner October 23, 2024 19:14
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link
Copy Markdown

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13984

@bitwarden-bot bitwarden-bot changed the title Added Futurex to list of supported PKCS #11 providers [PM-13984] Added Futurex to list of supported PKCS #11 providers Oct 23, 2024
@rr-bw rr-bw requested review from ike-kottlowski and removed request for rr-bw October 28, 2024 23:45
@bitwarden-bot
Copy link
Copy Markdown

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-5517

@trmartin4 trmartin4 removed request for a team and ike-kottlowski October 3, 2025 13:05
@djsmith85
Copy link
Copy Markdown

@bbarrows-futurex Apologies for the delay here. Could you please provide a description to your PR. This will help Product management to review and if approved passed on to Engineering.

Kind regards,
Daniel

@djsmith85 djsmith85 requested review from a team and mzieniukbw and removed request for a team February 10, 2026 16:27
Copy link
Copy Markdown
Contributor

@pixman20 pixman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

PR: [PM-13984] Added Futurex to list of supported PKCS #11 providers

Aspect Assessment
Risk Low
Type Feature addition
Security No concerns
Testing Adequate - test cases added for both Decrypt and Sign paths

Overview

Clean, well-structured community contribution that adds Futurex CryptoHub as a supported PKCS#11 HSM provider. All changes follow existing patterns exactly:

  • README.md - Updated provider comment to include futurex
  • KeyConnectorSettings.cs - Added futurex to the provider comment list
  • Pkcs11RsaKeyService.cs - Added library path mapping in the LoadLibrary switch expression
  • Pkcs11RsaKeyServiceTests.cs - Added InlineData test cases for both DecryptAsync and SignAsync library path resolution

No issues found. The change is purely additive, follows established conventions, and includes appropriate test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants