[PM-35442] Key connector not updating key via PUT#267
Open
mzieniukbw wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 7.04% 37.73% +30.69%
==========================================
Files 49 49
Lines 1818 1823 +5
Branches 99 99
==========================================
+ Hits 128 688 +560
+ Misses 1685 1100 -585
- Partials 5 35 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quexten
reviewed
May 26, 2026
quexten
reviewed
May 26, 2026
quexten
requested changes
May 26, 2026
|
quexten
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35442
📔 Objective
PUT /key-connector/user-keysrejects the request if the user already have the key in database - this PR fixes this bug.Also adds unit tests and integration test coverage.
📸 Screenshots