Skip to content

[BRE-2166] Add metadata to Key Connector container image - #286

Merged
vgrassia merged 10 commits into
mainfrom
bre-2166_add-metadata-to-container-images
Aug 31, 2026
Merged

[BRE-2166] Add metadata to Key Connector container image#286
vgrassia merged 10 commits into
mainfrom
bre-2166_add-metadata-to-container-images

Conversation

@vgrassia

@vgrassia vgrassia commented Aug 20, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

BRE-2166

📔 Objective

This PR adds metadata to the Key Connector container image. The metadata is useful for debugging issues and tracking when and where an image was built.

@vgrassia
vgrassia requested review from a team as code owners August 20, 2026 20:55
@vgrassia vgrassia added the ai-review Request a Claude code review label Aug 20, 2026
@vgrassia
vgrassia requested review from aj-bw and eligrubb August 20, 2026 20:55
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR updates .github/workflows/build.yml and .github/workflows/cleanup-container-images.yml, replacing both inline tag-generation scripts with the shared bitwarden/gh-actions/sanitize-image-tag action, adding OCI labels/annotations via docker/metadata-action, and enabling Buildx with provenance: mode=max. Cosign signing is extended to refs/tags/v* pushes and job-scoped contents: read was added to both workflows. Shell steps consistently pass untrusted values through env: rather than direct ${{ }} interpolation, third-party actions remain SHA-pinned, and bitwarden/gh-actions/*@main matches the existing convention in this repo. The Dockerfile takes no build args or secrets, so mode=max provenance carries no disclosure risk here.

The cross-workflow duplication flagged in the previous review has been resolved in 1ee0c6acleanup-container-images.yml now calls the same shared action.

Code Review Details
  • ❓ : Shared tag action's main → dev and refs/tags/vX.Y.Z → X.Y.Z mappings could not be verified; these paths are not exercised by PR CI
    • .github/workflows/build.yml:75-80

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.61%. Comparing base (fc3e405) to head (1ee0c6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   46.61%   46.61%           
=======================================
  Files          51       51           
  Lines        1830     1830           
  Branches       97       97           
=======================================
  Hits          853      853           
  Misses        933      933           
  Partials       44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgrassia
vgrassia enabled auto-merge (squash) August 20, 2026 22:29
Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml
@vgrassia
vgrassia merged commit b7d76b8 into main Aug 31, 2026
26 checks passed
@vgrassia
vgrassia deleted the bre-2166_add-metadata-to-container-images branch August 31, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants