[PM-36839] Prepare API base Error#1049
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR prepares Code Review DetailsNo new findings. Prior reviewer concerns (StatusCode type erasure, the |
🔍 SDK Breaking Change DetectionSDK Version:
Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
- Coverage 84.10% 84.10% -0.01%
==========================================
Files 446 446
Lines 58768 58769 +1
==========================================
Hits 49428 49428
- Misses 9340 9341 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djsmith85
left a comment
There was a problem hiding this comment.
Changes are looking great, just one question regarding removing type information.
djsmith85
left a comment
There was a problem hiding this comment.
Changes are looking great !
# Conflicts: # crates/bitwarden-api-base/src/lib.rs
|



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36839
📔 Objective
Prepare the Error type in
bitwarden-api-baseso it can be merged with the one inbitwarden-core. This requires:ErrorsuffixOnce this change is done, we can proceed with merging both error types, which is done on a separate PR as it involves basically every team: #1050
🚨 Breaking Changes