[PM-35105] Extract shared key-envelope helpers in bitwarden-crypto#1203
[PM-35105] Extract shared key-envelope helpers in bitwarden-crypto#1203quexten wants to merge 8 commits into
Conversation
Factors the duplicated key-decode and contained-key-id logic out of the symmetric-key and password-protected envelopes into shared helpers (decode_sealed_symmetric_key, extract_key_id, set_contained_key_id) on the safe module, and exposes set_header_value to the module. No behavior change.
🔍 SDK Breaking Change DetectionSDK Version:
Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## km/hazmat-cose-symmetric #1203 +/- ##
=========================================================
Coverage 85.16% 85.16%
=========================================================
Files 467 468 +1
Lines 64291 64295 +4
=========================================================
+ Hits 54754 54759 +5
+ Misses 9537 9536 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…dc2f6b56abd6adf9 (#1200) Updates the Identity bindings to `408002d1b6e6c6b6aee907c1dc2f6b56abd6adf9` Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
…ernal into km/safe-shared-helpers
|
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
1 participant
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35105
📔 Objective
Stacked PR 3/4 (on top of #1202).
Factors the duplicated key-decode and contained-key-id logic out of the symmetric-key and password-protected envelopes into shared helpers (
decode_sealed_symmetric_key,extract_key_id,set_contained_key_id) on thesafemodule, and exposesset_header_valueto the module. No behavior change.Base:
km/hazmat-cose-symmetric(#1202).