Skip to content

Add create-testvectors skill#1208

Open
quexten wants to merge 3 commits into
mainfrom
km/testvector-skill
Open

Add create-testvectors skill#1208
quexten wants to merge 3 commits into
mainfrom
km/testvector-skill

Conversation

@quexten

@quexten quexten commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

n/a

📔 Objective

Adds a create-testvectors Claude Code skill that documents how to record a serialized/encrypted format as a permanent test vector.

🚨 Breaking Changes

None.

@quexten quexten requested a review from a team as a code owner June 23, 2026 00:25
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of the create-testvectors Claude Code skill (.claude/skills/create-testvectors/SKILL.md), a documentation-only change. Verified the YAML frontmatter, the allowed-tools scoping, and that every referenced file, function, constant, and code example matches the actual implementations in bitwarden-crypto (data_envelope.rs and password_protected_key_envelope.rs). No security, correctness, or breaking-change concerns found.

Code Review Details

No actionable findings.

  • Frontmatter is valid; allowed-tools is appropriately scoped to Bash(cargo test:*) and Bash(npm run lint).
  • All cited references (generate_test_vectors, test_data_envelope_test_vector, seal_ref/unseal_ref, ExampleNamespace, TESTVECTOR_* consts, test_testvector_cosekey/test_testvector_legacykey) exist and match the codebase.
  • Code examples faithfully mirror the real reference tests; no broken links, no hardcoded secrets, no committed local settings.
  • The existing thread suggesting allowed-tools was already addressed by the author.

@quexten quexten enabled auto-merge (squash) June 23, 2026 00:32
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: km/testvector-skill (cb2530b)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
typescript ✅ No breaking changes detected Compilation passed with new SDK version - View Details
android ✅ No breaking changes detected Compilation passed with new SDK version - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@quexten quexten added the ai-review Request a Claude code review label Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.09%. Comparing base (4b41c1c) to head (2966cbb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   85.08%   85.09%   +0.01%     
==========================================
  Files         464      464              
  Lines       63781    63866      +85     
==========================================
+ Hits        54267    54348      +81     
- Misses       9514     9518       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SaintPatrck SaintPatrck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great skill. Overall this is excellent. Well scoped and concise. 👏

One minor suggestion to remove a couple permission prompts while the skill is doing its thing.

### 3. Run it and capture the output

```
cargo test -p <crate> <module>::tests::generate_test_vectors -- --ignored --nocapture

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Adding Bash(cargo test:*) and Bash(npm run lint) to allowed-tools will make these command executions more seamless. Users won't have to manually approve them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Applied!

@quexten quexten requested a review from SaintPatrck June 24, 2026 04:06
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants