Remove ecdsa-keys compilation flag#1209
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the temporary Code Review DetailsNo issues found. The cleanup is complete and self-consistent:
|
|
🔍 SDK Breaking Change DetectionSDK Version:
Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 85.09% 85.09% -0.01%
==========================================
Files 464 464
Lines 63866 63861 -5
==========================================
- Hits 54348 54343 -5
Misses 9518 9518 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
quexten
left a comment
There was a problem hiding this comment.
Does not need my explicit approval, but from @bitwarden/wg-ssh-keys side looks great.



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38832
📔 Objective
We built with this flag as the default in #1181
, and now that the ssh agent in the clients repo supports the key type, there isn't a reason to have the compilation flag anymore, so this change is to remove it and cleanup.