Skip to content

[BRE-1954] remove migrated deploy workflows#1211

Merged
AmyLGalles merged 1 commit into
mainfrom
agalles/remove-migrated-workflows
Jun 23, 2026
Merged

[BRE-1954] remove migrated deploy workflows#1211
AmyLGalles merged 1 commit into
mainfrom
agalles/remove-migrated-workflows

Conversation

@AmyLGalles

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-1952
Delete workflows that have been migrated to deploy repo

📔 Objective

🚨 Breaking Changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner June 23, 2026 23:08
@AmyLGalles AmyLGalles requested a review from aj-bw June 23, 2026 23:08
@AmyLGalles AmyLGalles enabled auto-merge (squash) June 23, 2026 23:08
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR deletes the release-rust-crates.yml workflow as part of migrating release/deploy logic to the deploy repository (BRE-1952/BRE-1954). The removed workflow was a workflow_dispatch-only job that created a draft GitHub release and rust-v* tag. The remaining publish-rust-crates.yml is independent (manually dispatched with a version input and already delegates to bitwarden/gh-actions/trigger-actions), so removing the release workflow does not break the publish path. No other workflows reference the deleted file or its rust-v* tag.

Code Review Details
  • ♻️ : Orphaned CODEOWNERS entry left behind by this deletion.
    • .github/CODEOWNERS:70 still references .github/workflows/release-rust-crates.yml, which this PR removes. The entry will no longer match any path and should be deleted to keep CODEOWNERS clean. (Noted here rather than inline since CODEOWNERS is not part of this PR's diff.)

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: agalles/remove-migrated-workflows (ad16f96)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
typescript ✅ No breaking changes detected Compilation passed with new SDK version - View Details
android ✅ No breaking changes detected Compilation passed with new SDK version - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@AmyLGalles AmyLGalles merged commit 9572944 into main Jun 23, 2026
69 checks passed
@AmyLGalles AmyLGalles deleted the agalles/remove-migrated-workflows branch June 23, 2026 23:29
bw-ghapp Bot added a commit to bitwarden/sdk-swift that referenced this pull request Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.09%. Comparing base (f20702c) to head (ad16f96).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files         464      464           
  Lines       63866    63866           
=======================================
  Hits        54348    54348           
  Misses       9518     9518           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants