Skip to content

Update pull request template#708

Merged
Hinton merged 1 commit into
mainfrom
arch/pr-templ
Jan 23, 2026
Merged

Update pull request template#708
Hinton merged 1 commit into
mainfrom
arch/pr-templ

Conversation

@Hinton

@Hinton Hinton commented Jan 23, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

📔 Objective

Update PR template to match bitwarden/template#181

@Hinton Hinton requested a review from a team as a code owner January 23, 2026 10:12
@Hinton Hinton requested a review from dani-garcia January 23, 2026 10:12
@github-actions

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details868e2f74-da54-421e-bc3b-e062f232fc04

Great job! No new security vulnerabilities introduced in this pull request

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection Results

SDK Version: arch/pr-templ (39b6e14)
Completed: 2026-01-23 10:19:58 UTC
Total Time: 32s

Client Status Details
typescript ❌ Breaking changes detected TypeScript compilation failed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov

codecov Bot commented Jan 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.58%. Comparing base (b8cddcf) to head (39b6e14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files         293      293           
  Lines       32767    32767           
=======================================
  Hits        26078    26078           
  Misses       6689     6689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djsmith85 djsmith85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually liked the reminders and the guidelines. I'd regularly look up the emojis when writing reviews. I also think it helps new devs and contributors to see what we are looking out for in a PR.

@djsmith85 djsmith85 removed the request for review from dani-garcia January 23, 2026 11:02
@Hinton

Hinton commented Jan 23, 2026

Copy link
Copy Markdown
Member Author

@djsmith85 I found them a bit verbose, but not disagreeing. This was updated in the other repos though so for consistency we should use the same template. Maybe there's a middle ground that won't confuse AI reviewers.

@Hinton Hinton merged commit c97bc92 into main Jan 23, 2026
59 checks passed
@Hinton Hinton deleted the arch/pr-templ branch January 23, 2026 11:03
bw-ghapp Bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants