Updating language wrappers and the CLI to calculate the correct value…#1516
Open
cd-bitwarden wants to merge 15 commits into
Open
Updating language wrappers and the CLI to calculate the correct value…#1516cd-bitwarden wants to merge 15 commits into
cd-bitwarden wants to merge 15 commits into
Conversation
… for ValueChanged when updating a secret's value
Update all sdk-internal dependencies (bitwarden-auth, bitwarden-cli, bitwarden-core, bitwarden-crypto, bitwarden-generators, bitwarden-sm) to the latest main branch commit (cc824ddc07c3e0b65b782b1c47d029c2af24f535).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
==========================================
- Coverage 15.15% 15.04% -0.12%
==========================================
Files 21 21
Lines 1194 1203 +9
==========================================
Hits 181 181
- Misses 1013 1022 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Calculate whether the secret value has changed by comparing with the existing secret before updating. This matches the C++ and Go implementations.
Add camelCase rename_all serde attribute to match the JSON field names sent by language bindings. The binding suse camelCase (valueChanged, projectIds) while the struct was expecting snake_case.
The Go and other language bindings send valueChanged in the secret update request, but the Rust SDK's SecretPutRequest doesn't include this field yet. Mark the field as optional with serde(default) so the fake server can deserialize requests that don't include it while still accepting and logging the value when present.
|
tangowithfoxtrot
approved these changes
May 28, 2026
Contributor
tangowithfoxtrot
left a comment
tangowithfoxtrot
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for ValueChanged when updating a secret's value
🎟️ Tracking
https://bitwarden.atlassian.net/jira/software/c/projects/SM/boards/74?assignee=625cb516fd06270069beaf5d&selectedIssue=SM-1595
📔 Objective
Updating the CLI and Language wrappers to properly detect and pass ValueChanged to the Update Secret API Endpoints when the value is changed.
🚨 Breaking Changes
Unsure, TBD.
For breaking changes:
Otherwise, you can remove this section. -->