BRE-1893 fix(marketplace): guard against non-interactive shells#520
Conversation
… shells [BRE-1893](https://bitwarden.atlassian.net/browse/BRE-1893) The first-login setup wizard prompts for the deployment edition via a `read` loop. When a non-interactive session sources it, the prompt blocks the session, so the session's commands never run. * Exit the wizard immediately when stdin or stdout is not a terminal, so non-interactive logins are never blocked * Make the read EOF-safe (`|| exit 0`) so a closed stdin cannot spin the selection loop
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds two defensive guards to Code Review DetailsNo findings. |
|
2 participants
🎟️ Tracking
BRE-1893
📔 Objective
The first-login setup wizard prompts for the deployment edition via a
readloop. When a non-interactive session sources it, the prompt blocks the session, so the session's commands never run.|| exit 0) so a closed stdin cannot spin the selection loop📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes