Replace deprecated tqdm_notebook with tqdm.auto - #42
Merged
Conversation
tqdm.auto auto-detects the environment (terminal, Jupyter notebook, Jupyter lab), removing the need for callers to choose between progress=True and progress='notebook'. The progress parameter is now a simple boolean.
Add type hints to trajectory_from_structures signature (Sequence[Structure], -> None). Group standard library imports together at the top. Capitalise docstring parameter description.
types-tqdm provides proper type stubs, consistent with the existing types-PyYAML and scipy-stubs dev dependencies.
Signals to type checkers that the package ships inline type annotations, consistent with the project's use of type hints throughout.
pymatgen ships its own type information and scipy-stubs is already a dev dependency, making both ignore_missing_imports entries unnecessary.
Run tests across 3.10-3.14 (with allow-prereleases for 3.14). Move static type checking into a dedicated job so it runs once rather than repeating across the version matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from tqdm import tqdm, tqdm_notebookwithfrom tqdm.auto import tqdm, which auto-detects the environment (terminal, Jupyter notebook, Jupyter lab)progressparameter to a plainbool— the'notebook'string option is no longer neededparamsdict and conditional branching