Fix texture conversion in the GL backend#2956
Open
goodartistscopy wants to merge 1 commit intobkaradzic:masterfrom
Open
Fix texture conversion in the GL backend#2956goodartistscopy wants to merge 1 commit intobkaradzic:masterfrom
goodartistscopy wants to merge 1 commit intobkaradzic:masterfrom
Conversation
The line as currently written disallows conversions (except swizzle) because `convert` can't be true if `compressed` isn't.
bkaradzic
requested changes
Oct 13, 2022
Owner
bkaradzic
left a comment
There was a problem hiding this comment.
Specify which format -> format conversion fails?
Flipping logic would disallow decompressing textures.
Contributor
Author
|
Conversion is fine but it's never called, because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line as currently written disallows conversions (except swizzle) because
convertcan't be true ifcompressedisn't.