Skip uniform names that contain .@data.#3155
Open
jay3d wants to merge 1 commit intobkaradzic:masterfrom
Open
Conversation
bkaradzic
requested changes
Aug 4, 2023
Owner
bkaradzic
left a comment
There was a problem hiding this comment.
This should be fixed on shaderc side to now allow .@data. to be treated as uniform.
..@data.
Contributor
Author
Done. |
Owner
|
Is this consistent behavior with D3D11? |
Contributor
Author
I have no idea, I found no such check there to begin with. |
Owner
I mean if you compile with D3D compiler you get exactly the same uniform name that you get with SPIRV after trimming |
c248aaf to
f16ad4a
Compare
5df4dd1 to
897d714
Compare
…forms (cherry picked from commit 897d714)
897d714 to
3c05424
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some instances where one would have a structured buffer such as:
Then the uniform name generated would be:
This would fail the uniform name validation check, because of the
.@data.in the name.