Skip to content

Fix crash reported in issue #24. Change ringtone manager #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix crash reported in issue #24. Change ringtone manager #25

wants to merge 8 commits into from

Conversation

icc-guerrero
Copy link
Contributor

  • RCT dismiss call crash fixed. Fixes Your new version crashed #24
  • Use RingtoneManager instead of AudioManager for playing the ringtone. Calls use now ringtone volume instead of media volume. Avoid ring sound if the device is in silent / do not disturb mode.

geraintwhite pushed a commit to geraintwhite/react-native-incoming-call that referenced this pull request Jun 14, 2022
@icc-guerrero
Fix crash reported in issue bkdev98#24. Change ringtone manager bkdev…
e3d1541 
…98#25
@geraintwhite geraintwhite mentioned this pull request Jun 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierguinzani pierguinzani pierguinzani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Your new version crashed
2 participants
@icc-guerrero @pierguinzani