Fix handshake for devices with custom BROM PIDs #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous handshake improvement (dad27fc) only checked for PID 0x3 to identify BROM mode, but this broke compatibility with devices using custom vendor/product IDs for BROM, such as Sony phones (0x0FCE:0xF200, 0x0FCE:0xD1E9, etc.). BROM does not expect the initial 0xa0 byte and will hang if it's sent. Workaround this by expanding the BROM detection logic to include all known BROM PIDs. Change-Id: I4cf55f12d469b27f964f0f4e9ace6822086a91d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous handshake improvement (dad27fc) only checked for PID 0x3 to identify BROM mode, but this broke compatibility with devices using custom vendor/product IDs for BROM, such as Sony phones (0x0FCE:0xF200, 0x0FCE:0xD1E9, etc.).
BROM does not expect the initial 0xa0 byte and will hang if it's sent. Workaround this by expanding the BROM detection logic to include all known BROM PIDs.