Add files via upload

[Zazk0u]

No description provided.

[Zazk0u]

For context i made a python mod, i hope i did not messed this up

[apple1417]

Few things about your pyproject:

• All the base stuff under project is standard python packaging fields. project.name may not contain spaces. That's why you can overwrite it under the sdkmod section. This is the one thing that actually needs changing, rest are just suggestions.
• The SDK assumes the first author is the main author, you may want to put yourself first
• Your pyproject doesn't specify the license, your repo uses gpl3

And then suggestions for your code:

• You probably meant to set the option descriptions, not description titles
• You only need to use the global statement if you're setting a global, you can always read one
• In request_skill_upgrade it sounds like you'd be better off using unrealsdk.find_enum than magic numbers
• In fake_level_five, that getattr is useless, it's just setting func back to what it already was.
• You might consider splitting fake_level_five into a seperate pre/post hook, so that you don't need to block execution. This will play better if any other mod hooks the same functions.

[Zazk0u]

Will change the project and clean the code, thanks for the suggestions. Le lun. 14 juil. 2025 à 20:58, apple1417 ***@***.***> a écrit :

…

*apple1417* left a comment (bl-sdk/bl-sdk.github.io#104) <#104 (comment)> Few things about your pyproject: - All the base stuff under project is standard python packaging fields. project.name may not contain spaces <https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#name>. That's why you can overwrite it under the sdkmod section. This is the one thing that actually needs changing, rest are just suggestions. - The SDK assumes the first author is the main author, you may want to put yourself first And then suggestions for your code: - You probably meant to set the option descriptions, not description titles - You only need to use the global statement if you're setting a global, you can always read one - In request_skill_upgrade it sounds like you'd be better off using unrealsdk.find_enum than magic numbers - In fake_level_five, that getattr is useless, it's just setting func back to what it already was. - You might consider splitting fake_level_five into a seperate pre/post hook, so that you don't need to block execution. This will play better if any other mod hooks the same functions. — Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARHVK3RZ6SVXBEDDZXXU7CL3IP4UHAVCNFSM6AAAAACBPRILVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZQGYZTMNZRGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Zazk0u]

I've updated my pyproject and followed your suggestions.
Hopefully i did not mess anything up with the merge branch, i'm not super into github.