Skip to content

pyright linting fixups #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
+11 −8
Merged

pyright linting fixups #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cruft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"template": "[email protected]:bl-sdk/common_dotfiles.git",
"commit": "3d7189e61172cb95877261df8313ae595fe6c02d",
"commit": "cee5c9dbf5b95f57bb636e5138171aa6a4964cf1",
"checkout": null,
"context": {
"cookiecutter": {
Expand All @@ -16,7 +16,7 @@
"include_cpp": false,
"include_py": true,
"_template": "[email protected]:bl-sdk/common_dotfiles.git",
"_commit": "3d7189e61172cb95877261df8313ae595fe6c02d"
"_commit": "cee5c9dbf5b95f57bb636e5138171aa6a4964cf1"
}
},
"directory": null
Expand Down
7 changes: 5 additions & 2 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ a message as the second (both positionally), and show them in a temporary messag

# Changelog

### v1.6
- Linting fixes.

### v1.5
- Support host-only coop support value
- Linting fixes
- Support host-only coop support value.
- Linting fixes.

### v1.4
- Improved suggestions when trying to bind a key by name, and misspelling it.
Expand Down
2 changes: 1 addition & 1 deletion __init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"__version_info__",
)

__version_info__: tuple[int, int] = (1, 5)
__version_info__: tuple[int, int] = (1, 6)
__version__: str = f"{__version_info__[0]}.{__version_info__[1]}"
__author__: str = "bl-sdk"

Expand Down
2 changes: 1 addition & 1 deletion screens/home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
class HomeScreen(AbstractScreen):
name: Literal["Mods"] = "Mods" # pyright: ignore[reportIncompatibleVariableOverride]

drawn_mod_list: list[Mod] = field(default_factory=list, init=False)
drawn_mod_list: list[Mod] = field(default_factory=list[Mod], init=False)

def draw(self) -> None: # noqa: D102
draw_stack_header()
Expand Down
4 changes: 2 additions & 2 deletions screens/mod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
class OptionListScreen(AbstractScreen):
mod: Mod

drawn_options: list[BaseOption] = field(default_factory=list, init=False)
drawn_options: list[BaseOption] = field(default_factory=list[BaseOption], init=False)

@staticmethod
def any_option_visible(options: Sequence[BaseOption]) -> bool:
Expand Down Expand Up @@ -94,7 +94,7 @@ def draw_options_list(
stack.pop()

case ValueOption():
j_option: ValueOption[JSON] = option
j_option: ValueOption[JSON] = option # pyright: ignore[reportUnknownVariableType]

draw(
f"[{drawn_idx}] {option.display_name} ({get_option_value_str(j_option)})",
Expand Down