fix tps hooks #47
Merged
fix tps hooks #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it's enabled, we generate more log messages than the standard logging queue can keep up with. If logging to console in bl2/tps it actually recurses, every log generates half a dozen more calls which it all has to log too. Swapping to a dedicated file, and doing blocking writes helps avoid this, and also means we don't lose as much data if interrupted. Don't want to flush on every line to avoid killing performance even more.
Seems this has been broken a long time. The ghidra script which generates the signatures decided the stack offset was a perfectly sane constant to hardcode in. While the signature didn't match CallFunction in TPS, it did still match something, so we never got any logs about a null pointer. This fixes missing a lot of hooks - most notably the say bypass.
ran into this a lot while debugging the say bypass not working in tps (see last commit) since that was annoying, and we kind of want everyone to have it anyway, might as well include here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.