-
Notifications
You must be signed in to change notification settings - Fork 13
Add Save Options Module #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like most of the errors, bar the one spelling, are unrelated, and just broke due to newer releases. I'll get a fix in for them soon-ish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge in/rebase on top of current master, which should fix the unrelated errors. Will merge when all checks pass.
Module that enables saving arbitrary json-encodable data directly to the character save file. Original issue here:
#1
The module extends mods_base.ValueOption and its subclasses by adding a set of SaveOption classes. The classes behave almost exactly like their parents, except their values are saved to the save file instead of to the mod's settings file.
Some changes to note since apple's informal code review a few weeks ago: