Load default values for save options #59
Conversation
… save option data
src/save_options/options.py
Outdated
| For GroupedOption and NestedOption, recursively sets all children to their default values. | ||
| """ | ||
| if isinstance(save_option, ValueOption): |
There was a problem hiding this comment.
Nitpick: if you were to edit this code again I'd prefer using a match. Fine as is.
There was a problem hiding this comment.
I need to edit this part anyway since it's causing the pyright issue. Not sure why IDE and pyright CLI checks are out of sync on this, but I've got my env set up to check the latter now too.
Think I need to do:
val_opt = cast(ValueOption[Any], save_option)
Are you okay with this? I know you mentioned trying to avoid casts since there's actual overhead.
There was a problem hiding this comment.
Yeah seems we have to use it now...
There was a problem hiding this comment.
I suspect this comes from build 399
Extended
reportUnknownVariableTypecheck to include cases where a value whose type is a generic class parameterized by Unknown is assigned to a variable with a declared type.
2 participants
Adds functionality for all registered save options to be reverted to default when a save file is loaded, before the custom save data is loaded into the options. This fixes an issue where characters with no custom save data inherited option values from whatever character was last loaded.
Grouped and nested options have all their children set to default recursively.