This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix NULL jtagtap_cycle() which crashed BMDA#2179
Merged
Merged
Conversation
dragonmux
suggested changes
Jan 28, 2026
6 tasks
1967df4 to
a98061e
Compare
Contributor
Author
|
Now that all three affected backends have got some implementations of that, commits 1-2 can be discarded (explicit NULL and a nullcheck at callsite). |
dragonmux
reviewed
Jan 29, 2026
Member
dragonmux
left a comment
There was a problem hiding this comment.
This is looking better - we've got one review note that applies in a couple of places which is just about layout, otherwise LGTM 👍🏼
a98061e to
7e35068
Compare
dragonmux
approved these changes
Jan 29, 2026
Member
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging. Thank you for the contribution! We'll backport this just like we did the JTAG scan fix as this fixes a v2.0 bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
jtag_proc.jtagtap_cycle()in initial JTAG scan.jtagtap_next()).Affected backends are FTDI MPSSE, J-Link, and CMSIS-DAP.
Unaffected backends are BMP HL remote, STLINK. BMF was not affected either.
Tested with FT2232HL against a RV32I target, the other 3 callsites are not fixed.
Your checklist for this pull request
Closing issues